Issue #49: Adding accesibility to checkbox,button as well a radio button. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Not having accessibility feature in checkboxes ,buttons as well as radio buttons.
I wanted to contribute to the code as per what I've checked the keyboard accessibility was totally working for checkbox and buttons but there was no outline appearing for the same .
In case of radio buttons even though u could toggle a radio with tab and select but after it you cannot move further to select next radio button.
solutions:
1-> Solved for buttons by simply providing an outline: "auto" when we focus into the component and clicking on space was already enabled.
2-> For checkboxes as we are hiding original HTML checkbox but on pressing the tab or changing the value the focus goes to the original checkbox element because of which the outline visible outside the checkbox component on focus gets removed for this I added a ref to html checkbox to be controlled from our custom component
3-> For radio buttons I simply added tab indexing and accessibility